Skip to content

🌱 Add back more v1beta1 util functions from v1.10.3 #12441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

🌱 Add back more v1beta1 util functions from v1.10.3 #12441

wants to merge 1 commit into from
+4,805 −0

Conversation

pierreprinetti
Copy link

@pierreprinetti pierreprinetti commented Jul 3, 2025 •
edited
Loading

What this PR does / why we need it:

With v1beta2, some v1beta1 util functions have been saved in util/deprecated/v1beta1 for consumers that still support v1beta1 objects. This patch adds more v1beta1-focused utils packages to the deprecated/v1beta1 folder:

  • util
  • util/annnotations
  • util/collections
  • util/predicates

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #12440

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 3, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/needs-area PR is missing an area label label Jul 3, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign justinsb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 3, 2025
@pierreprinetti pierreprinetti force-pushed the util_v1beta1 branch 2 times, most recently from d251550 to eb447f1 Compare July 3, 2025 13:57
@pierreprinetti pierreprinetti marked this pull request as ready for review July 3, 2025 14:03
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 3, 2025
@k8s-ci-robot k8s-ci-robot requested a review from JoelSpeed July 3, 2025 14:03
@pierreprinetti pierreprinetti force-pushed the util_v1beta1 branch 2 times, most recently from 03bd179 to 2d58e55 Compare July 3, 2025 14:42
@pierreprinetti pierreprinetti mentioned this pull request Jul 3, 2025
Open
3 tasks
@pierreprinetti
Copy link
Author

/area util

@k8s-ci-robot k8s-ci-robot added area/util Issues or PRs related to utils and removed do-not-merge/needs-area PR is missing an area label labels Jul 3, 2025
@pierreprinetti
Add back more v1beta1 util functions from v1.10.3
b77e212 
With v1beta2, some v1beta1 util functions have been saved in
util/deprecated/v1beta1 for consumers that still support v1beta1
objects. This patch adds more v1beta1-focused utils packages to the
deprecated/v1beta1 folder:

* util
* util/annnotations
* util/collections
* util/predicates
@k8s-ci-robot
Copy link
Contributor

@pierreprinetti: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-test-main b77e212 link true /test pull-cluster-api-test-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@fabriziopandini
Copy link
Member

fabriziopandini commented Jul 3, 2025 •
edited
Loading

@pierreprinetti what is the use case for restoring this utils?
Have you read the recommendation from first point in https://main.cluster-api.sigs.k8s.io/developer/providers/migrations/v1.10-to-v1.11#suggested-changes-for-providers (conditions utils are so far the only temporary exception to this rule, but everything else v1beta1 is going away for good reasons)

@fabriziopandini fabriziopandini mentioned this pull request Jul 4, 2025
Closed
@fabriziopandini
Copy link
Member

/close

As per kubernetes-sigs/cluster-api-provider-openstack#2611 (comment)

That is: CAPO controllers will consume CAPI v1beta2 objects, but will themselves continue to publish infra objects conforming to CAPI v1beta1. We've been set a deadline of August next year to move to v1beta2, though, so we should probably get on that.

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: Closed this PR.

In response to this:

/close

As per kubernetes-sigs/cluster-api-provider-openstack#2611 (comment)

That is: CAPO controllers will consume CAPI v1beta2 objects, but will themselves continue to publish infra objects conforming to CAPI v1beta1. We've been set a deadline of August next year to move to v1beta2, though, so we should probably get on that.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pierreprinetti pierreprinetti deleted the util_v1beta1 branch July 14, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardcase richardcase Awaiting requested review from richardcase

@vincepri vincepri Awaiting requested review from vincepri

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees
No one assigned
Labels
area/util Issues or PRs related to utils cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v1beta1-compatible util functions in v0.11
3 participants
@pierreprinetti @k8s-ci-robot @fabriziopandini